Fix essentials.home.bed permission being ignored#6516
Open
JRoy wants to merge 1 commit intoEssentialsX:2.xfrom
Open
Fix essentials.home.bed permission being ignored#6516JRoy wants to merge 1 commit intoEssentialsX:2.xfrom
JRoy wants to merge 1 commit intoEssentialsX:2.xfrom
Conversation
Two paths bypassed the permission check:
1. Explicit /home bed: the permission check at line 44 was combined
with the bed-spawn logic in a single condition. When denied, it
fell through to goHome("bed") which found the stored bed home
by name and teleported anyway. Now rejects immediately.
2. Fallback respawn: when a player has no homes and isSpawnIfNoHome
is true, respawn() was called unconditionally which tries the bed.
Now checks the permission and falls back to world spawn when denied.
Fixes EssentialsX#5963
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two paths bypassed the permission check:
Explicit /home bed: the permission check at line 44 was combined
with the bed-spawn logic in a single condition. When denied, it
fell through to goHome("bed") which found the stored bed home
by name and teleported anyway. Now rejects immediately.
Fallback respawn: when a player has no homes and isSpawnIfNoHome
is true, respawn() was called unconditionally which tries the bed.
Now checks the permission and falls back to world spawn when denied.
Fixes #5963